Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1631790 transport layer #963

Merged
merged 9 commits into from
Dec 5, 2024
Merged

SNOW-1631790 transport layer #963

merged 9 commits into from
Dec 5, 2024

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.39326% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (cf7b3a3) to head (6c27246).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/http/base.js 82.97% 8 Missing ⚠️
lib/http/node.js 83.33% 4 Missing ⚠️
lib/connection/connection_config.js 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   88.98%   88.99%   +0.01%     
==========================================
  Files          69       70       +1     
  Lines        6764     6825      +61     
==========================================
+ Hits         6019     6074      +55     
- Misses        745      751       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review November 19, 2024 08:03
@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner November 19, 2024 08:03
@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Snow 1631790 transport layer SNOW-1631790 transport layer Nov 19, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki mentioned this pull request Nov 21, 2024
Closed
5 tasks
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer - Base HTTP client implemented
6ccbf7a
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer - Base http client logging splitted into…
2f41160 
… utils and main
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer - Removed absent parameters from the doc…
e2a499d 
…s. Added logs for node.js http client. Renamed utils file to comply with convention.
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer - Improved readability by renaming varia…
21772f5 
…bles. Fixed comments styling.
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer - missing logs added for browser client
12041dd
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer: Partial Identification of the HttpClien…
a93ecfd 
…t using connection config added.
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer: Proxy description added to logs
eb9c007
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer: Proxy redundant calls to getter eliminated
3271d0a
@sfc-gh-fpawlowski @sfc-gh-pmotacki
SNOW-1631790-Transport-Layer: Masking Tokens for '%' signs and parame…
6c27246 
…ters describing token prefixing it fixed.
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1631790-Transport-Layer branch from adb13c4 to 6c27246 Compare December 5, 2024 10:20
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit b74508b into master Dec 5, 2024
58 of 59 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the SNOW-1631790-Transport-Layer branch December 5, 2024 11:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dheyman sfc-gh-dheyman sfc-gh-dheyman approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-fpawlowski @sfc-gh-pmotacki @sfc-gh-dheyman